Fix NBA Boxscores using the wrong home values #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #505 +/- ##
=======================================
Coverage 99.97% 99.97%
=======================================
Files 55 55
Lines 13084 13091 +7
=======================================
+ Hits 13081 13088 +7
Misses 3 3
Continue to review full report at Codecov.
|
The Boxscores pages on sports-reference.com were changed to include scores by halves and quarters, which retrieved the incorrect values for the home team as it was instead pulling the first-quarter stats for the away team. By using a new index to retrieve values from, the proper stats can be displayed for the home team. Signed-Off-By: Robert Clark <robdclark@outlook.com>
roclark
force-pushed
the
fix-nba-boxscore-home-stats
branch
from
3c8901e
to
95384d0
Compare
roclark
added
the
hacktoberfest-accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Boxscores pages on sports-reference.com were changed to include scores by halves and quarters, which retrieved the incorrect values for the home team as it was instead pulling the first-quarter stats for the away team. By using a new index to retrieve values from, the proper stats can be displayed for the home team.
Fixes #498
Signed-Off-By: Robert Clark robdclark@outlook.com